Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datahub] [Redesign] Thumbail preview #779

Merged
merged 6 commits into from
Feb 14, 2024
Merged

[Datahub] [Redesign] Thumbail preview #779

merged 6 commits into from
Feb 14, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jan 24, 2024 •
edited
Loading

WIP

Description

This PR introduces changes for the redesign of the thumbnail image. It includes the following changes :

  • Move the contact & lightbox section up in the about section
  • Increase thumbnail size
  • e2e tests

Architectural changes

Added basiclightbox library.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • The documentation website 📚 has received the love it deserves

This work is sponsored by GeoCat.

@cmoinier cmoinier marked this pull request as ready for review January 24, 2024 22:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited
Loading

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Jan 24, 2024 •
edited
Loading

Coverage Status

coverage: 86.293% (+4.0%) from 82.294%
when pulling ef53f8d on DH/redesign-lightbox
into 0da0455 on main.

jahow
jahow reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I think some unintentional changes slipped through, could you try and see if you can narrow down what was really intended? thanks!

apps/datahub/src/app/record/record-metadata/record-metadata.component.html Outdated Show resolved Hide resolved
libs/ui/elements/src/lib/image-overlay-preview/image-overlay-preview.component.html Outdated Show resolved Hide resolved
libs/ui/elements/src/lib/metadata-contact/metadata-contact.component.html Outdated Show resolved Hide resolved
@jahow
Copy link
Collaborator

jahow commented Feb 14, 2024

I amended this PR to address the issues, we changed the position of the md quality indicator like so:
image

@cmoinier cmoinier merged commit 0c46720 into main Feb 14, 2024
9 checks passed
@cmoinier cmoinier deleted the DH/redesign-lightbox branch February 14, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmoinier @coveralls @jahow